<html>
<head><meta charset="utf-8"><title>meeting 2021-04-21 · t-libs/meetings · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/index.html">t-libs/meetings</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html">meeting 2021-04-21</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="235540299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235540299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235540299">(Apr 21 2021 at 16:25)</a>:</h4>
<p>hey <span class="user-group-mention" data-user-group-id="2645">@T-libs</span>! we have our regular meeting scheduled in a bit less than three hours. However, this time we have zero rfcs, zero nominated items, and zero waiting-on-team items waiting for us (not counting those we already discussed last time). We do however have 27 PRs and some issues waiting for a review/response. So I was thinking to maybe skip the meeting this week and instead spend this time working on reviews etc. Or does anyone have something we should discuss today?</p>



<a name="235540382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235540382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235540382">(Apr 21 2021 at 16:25)</a>:</h4>
<p>Sounds good to me. Do you have a link for the PRs to review?</p>



<a name="235540933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235540933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235540933">(Apr 21 2021 at 16:29)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-libs+label%3AS-waiting-on-review">Here</a> are all the S-waiting-on-review items for T-libs, and <a href="https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-libs-impl+label%3AS-waiting-on-review+">here</a> for T-libs-impl. Almost all of them have quite a long discussion thread going on though, so quite possibly it's blocked om some design decision or something. And some might just be mislabeled.</p>



<a name="235541217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235541217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235541217">(Apr 21 2021 at 16:31)</a>:</h4>
<p>Oh and we still need to respond to <a href="https://github.com/rust-lang/rust/pull/76901">https://github.com/rust-lang/rust/pull/76901</a> i see in our action items list.</p>



<a name="235542186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235542186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235542186">(Apr 21 2021 at 16:36)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="235542199"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235542199" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235542199">(Apr 21 2021 at 16:36)</a>:</h4>
<p>Review we shall</p>



<a name="235542245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235542245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235542245">(Apr 21 2021 at 16:37)</a>:</h4>
<p>My plan for today is to do the rewrite of the error handling blog post based on Niko's feedback</p>



<a name="235542266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235542266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235542266">(Apr 21 2021 at 16:37)</a>:</h4>
<p>oh nice!</p>



<a name="235542346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235542346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235542346">(Apr 21 2021 at 16:37)</a>:</h4>
<p>So I'll probably focus on that and work on reviews once I take a break</p>



<a name="235544866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235544866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235544866">(Apr 21 2021 at 16:55)</a>:</h4>
<p>Reviewing those sounds great. Should we do that in this thread, or another thread?</p>



<a name="235567874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235567874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235567874">(Apr 21 2021 at 19:30)</a>:</h4>
<p>I'm looking at <a href="https://github.com/rust-lang/rust/pull/81642">https://github.com/rust-lang/rust/pull/81642</a> , and it seems very reasonable to me. It needs a feature gate, but otherwise, I think we ought to merge it. Any objections?</p>



<a name="235569047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235569047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235569047">(Apr 21 2021 at 19:38)</a>:</h4>
<p>posted a comment</p>



<a name="235569952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235569952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235569952">(Apr 21 2021 at 19:45)</a>:</h4>
<p>Good point. Followed up with an alternative suggestion.</p>



<a name="235570038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235570038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235570038">(Apr 21 2021 at 19:46)</a>:</h4>
<p>I posted review comments to a few more PRs, and re-labeled them as <code>S-waiting-on-author</code>.</p>



<a name="235570591"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235570591" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235570591">(Apr 21 2021 at 19:50)</a>:</h4>
<p><span class="user-mention" data-user-id="310399">@Mara</span> Given that the comments about doc aliases specifically used <code>free</code> as an example of what we don't want (because there's no explanation and it could come across wrong), could you post the same explanation to <a href="https://github.com/rust-lang/rust/pull/83967">https://github.com/rust-lang/rust/pull/83967</a> please?</p>



<a name="235570872"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235570872" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235570872">(Apr 21 2021 at 19:52)</a>:</h4>
<p>sure!</p>



<a name="235570965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235570965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235570965">(Apr 21 2021 at 19:53)</a>:</h4>
<p>i think we should just remove <code>#[doc(alias = "delete")]</code> from <code>fn drop</code></p>



<a name="235571318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571318">(Apr 21 2021 at 19:55)</a>:</h4>
<p>Agreed.</p>



<a name="235571340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571340">(Apr 21 2021 at 19:56)</a>:</h4>
<p>If you want to post a PR for that, I'll r+ it.</p>



<a name="235571464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571464">(Apr 21 2021 at 19:56)</a>:</h4>
<p>I think <a href="https://github.com/rust-lang/rust/pull/79943">https://github.com/rust-lang/rust/pull/79943</a> is a relatively reasonable use of aliases, but I think we need more of a consensus on whether we want to set the precedent of using aliases for "we could have also called this...".</p>



<a name="235571492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571492">(Apr 21 2021 at 19:56)</a>:</h4>
<p>yes one second, was just opening the tree again. fix was merged <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="235571539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571539">(Apr 21 2021 at 19:57)</a>:</h4>
<p>yay, bors is open for business again</p>



<a name="235571564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571564">(Apr 21 2021 at 19:57)</a>:</h4>
<p>Ah, what was the fix?</p>



<a name="235571757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571757">(Apr 21 2021 at 19:58)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/259402-t-libs.2Fmeetings/topic/meeting.202021-04-21/near/235571340">said</a>:</p>
<blockquote>
<p>If you want to post a PR for that, I'll r+ it.</p>
</blockquote>
<p><a href="https://github.com/rust-lang/rust/pull/84406">https://github.com/rust-lang/rust/pull/84406</a></p>



<a name="235571890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235571890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235571890">(Apr 21 2021 at 19:59)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/259402-t-libs.2Fmeetings/topic/meeting.202021-04-21/near/235571564">said</a>:</p>
<blockquote>
<p>Ah, what was the fix?</p>
</blockquote>
<p>See <a href="#narrow/stream/242791-t-infra/topic/expat.20gone.20missing.20from.20sourceforge/near/235513336">https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/expat.20gone.20missing.20from.20sourceforge/near/235513336</a></p>



<a name="235574202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235574202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235574202">(Apr 21 2021 at 20:14)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/259402-t-libs.2Fmeetings/topic/meeting.202021-04-21/near/235571464">said</a>:</p>
<blockquote>
<p>I think <a href="https://github.com/rust-lang/rust/pull/79943">https://github.com/rust-lang/rust/pull/79943</a> is a relatively reasonable use of aliases, but I think we need more of a consensus on whether we want to set the precedent of using aliases for "we could have also called this...".</p>
</blockquote>
<p><a href="https://github.com/rust-lang/rust/pull/79943#issuecomment-824328655">replied</a></p>



<a name="235586000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/meeting%202021-04-21/near/235586000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/meeting.202021-04-21.html#235586000">(Apr 21 2021 at 21:33)</a>:</h4>
<p>Thanks everyone for all the reviews today. We made a ton of progress!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>